FE: Adding Schema (Value) and Schema (Key) tab to the Topic details view #4020
+128
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two tabs will allow for quick access to the schemas for the messages produced to the topic. Meaningful debug message is shown if schema is not available for either topic key or topic value and hasSchemaRegistryConfigured is true. Tabs are not shown if hasSchemaRegistryConfigured is not true.
Mgrdich
reviewed
Jul 9, 2023
Mgrdich
reviewed
Jul 10, 2023
| getAreSchemaLatestRejected, | ||
| SCHEMA_LATEST_FETCH_ACTION, | ||
| } from 'redux/reducers/schemas/schemasSlice'; | ||
| import LatestVersionItem from '../../../Schemas/Details/LatestVersion/LatestVersionItem'; |
There was a problem hiding this comment.
can we please use absolute path here instead of an relative path ?
cause that way it will not cause any issues if we displaced the component that this Schema uses.
There was a problem hiding this comment.
Sure, no worries let me fix that, when I'm home from vacation at my computer with this code 😊
There was a problem hiding this comment.
@Mgrdich let's chill with the review, we might not need it, as I asked to raise a PR for an example, since we wanted to achieve something similar but not that similar :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two tabs will allow for quick access to the schemas for the messages produced to the topic.
Meaningful debug message is shown if schema is not available for either topic key or topic value and hasSchemaRegistryConfigured is true.
Tabs are not shown if hasSchemaRegistryConfigured is not true.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)